Attention is currently required from: Elyes Haouas, Felix Singer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75496?usp=email )
Change subject: Docs: Add help target and .phony identifiers
......................................................................
Patch Set 2:
(2 comments)
File Documentation/Makefile:
https://review.coreboot.org/c/coreboot/+/75496/comment/1d05ce5c_d831b1c2 :
PS1, Line 57: help:
nit: add an empty line before the help target
Done
https://review.coreboot.org/c/coreboot/+/75496/comment/62b524a6_8027f4b0 :
PS1, Line 60: @echo "livesphinx - Broken??? should this be deleted?"
Probably not meant to be submitted? I will have a look later.
removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75496?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie61d44d87e8628e12d01f3355360e2a679b5ce85
Gerrit-Change-Number: 75496
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 02 Jun 2023 22:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment