Attention is currently required from: Felix Singer, Furquan Shaikh, Matt DeVillier, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51663 )
Change subject: mb/purism/librem_mini: Drop superfluous devices from devicetree
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The `.on_mainboard` field of `struct device` would be wrong.
It's hard to get right, though, if you need to attach a "chip"
driver to something in a slot (we'd have a false positive
`.on_mainboard = 1`). But that's a deficiency of the drivers
that pretend to be chip drivers but aren't.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5f2e34d98b236f9cfac9f0afd8a8017e349603f
Gerrit-Change-Number: 51663
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 20 Mar 2021 16:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment