Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 )
Change subject: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory ......................................................................
Patch Set 2: Code-Review+1
(9 comments)
https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG@7 PS2, Line 7: not having without
https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG@10 PS2, Line 10: warning I see CB:45131 and "fail build" isn't just a warning
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/asrock/h110m/... PS2, Line 14: select GENERIC_SPD_BIN OK: Has DIMM slots
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/auron/... File src/mainboard/google/auron/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/auron/... PS2, Line 18: select GENERIC_SPD_BIN OK: Buddy is a Chromebase and has DIMM slots: https://www.reddit.com/r/chrultrabook/comments/fyr0qm/acer_chromebase_24_bud...
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/fizz/K... File src/mainboard/google/fizz/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/fizz/K... PS2, Line 25: select GENERIC_SPD_BIN OK: Fizz is a Chromebox (except Endeavour, which seems to be a server-like thing with TPUs). Also, it selects SPD_READ_BY_WORD
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarien... File src/mainboard/google/sarien/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarien... PS2, Line 12: select GENERIC_SPD_BIN Seems to be correct, since this is mutually exclusive with SPD_READ_BY_WORD. However, there's no information about this thing anywhere.
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/coffeel... PS2, Line 7: select GENERIC_SPD_BIN OK: RVPs often have DIMM slots. Plus, the current code only allows reading SPDs from SMBus
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/saddleb... File src/mainboard/intel/saddlebrook/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/saddleb... PS2, Line 9: select GENERIC_SPD_BIN OK: Seems to have memory slots, but the only picture I could find of this board is tiny: https://autocad.space/wp-content/uploads/saddle_brook_small.png
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/prodrive/herm... PS2, Line 5: select GENERIC_SPD_BIN OK: Server board, has DIMM slots
-
Angel Pons (Code Review)