Attention is currently required from: Arthur Heymans, Felix Singer, Jérémy Compostella.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83563?usp=email )
Change subject: arch/x86/Makefile.mk: Remove obsolete romcc reference
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/sandybridge/mrc_wrapper.S:
https://review.coreboot.org/c/coreboot/+/83563/comment/2b788bea_76c758a5?usp... :
PS2, Line 35: #include <cpu/x86/64bit/prot2long.inc>
I guess this change is needed because of the removed `-I` directive
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57a3a6e1c2cf7cf30fb0cd94cc8455f715050490
Gerrit-Change-Number: 83563
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 19 Jul 2024 08:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No