Attention is currently required from: Lance Zhao, Angel Pons, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51638 )
Change subject: ChromeOS: Separate NVS from global GNVS
......................................................................
Patch Set 4:
(1 comment)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/51638/comment/35c062dc_fa64ed19
PS4, Line 43: chromeos_init_chromeos_acpi
am I missing something? doesn't this patch effectively drop generating chromeos nvs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide55964ed53ea1d5b3c1c4e3ebd67286b7d568e4
Gerrit-Change-Number: 51638
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:36:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment