[S] Change in coreboot[master]: intel/cmn/smm: Introduce PERIODIC_SMI_RATE_SELECTION_IN_GEN_PMCON_B

[Maximilian Brune (Code Review)]

Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons, Krystian Hebel.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69870 )

Change subject: intel/cmn/smm: Introduce PERIODIC_SMI_RATE_SELECTION_IN_GEN_PMCON_B
......................................................................

Patch Set 4:

(1 comment)

File src/soc/intel/common/block/smm/Kconfig:

https://review.coreboot.org/c/coreboot/+/69870/comment/37d8d3f3_5e1852ef 
PS4, Line 53: 	  Intel Core processors select the periodic SMI rate via GEN_PMCON_A.
> Maybe if the discrepancy was much higher, but for now only the apollolake has been identified with s […]

You are right if its stays to being just one implementation there is no real difference in code size.
But since your implementation in CB:68944 is really just changing one line depending on the Kconfig option, I find it easier to read. But I am fine with either implementation.