Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27876 )
Change subject: soc/amd/stoneyridge: Prevent reboot in romstage ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/27876/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27876/1//COMMIT_MSG@7 PS1, Line 7: Prevent reboot in romstage
Maybe change this to what it does? This description is just ASKING for trouble. […]
Done
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 609: =
You don't really need to or the bit in either here or below, do you?
Done
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 614: // Undocumented register
This might be the spot to mention that it's an undocumented register.
Done
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 615: = misc_r
use BIT(16) from types. […]
Done
-
Raul Rangel (Code Review)