Attention is currently required from: Angel Pons, Matt DeVillier.
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86093?usp=email )
Change subject: mb/erying/tgl: Drop specifying which timers to use ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86093/comment/a6b65c5d_4dddd2f3?usp... : PS2, Line 1: Parent: 9dee482a (mb/google/nissa/var/telith: Configure Acoustic noise mitigation)
I'm confused, the Kconfigs in question aren't about X2APIC
Right, sorry, two separate things. This one is about recovering from "sleep".
Mainboard has broken S3 state, so I left s0ix enabled (after removing `HAVE_ACPI_RESUME`. However, if legacy timer is enabled, system will hang when it's trying to enter s0ix.
Without any of those timers enabled, system "enters" s0ix state and stays there until you press a button on the keyboard/case to wake it up.
It only enters it partially since SIO doesn't cut the power, but at least you can recover from accidental sleep state without losing your data.
-
Alicja Michalska (Code Review)