build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 )
Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ......................................................................
Patch Set 21: Verified-1
(10 comments)
File tests/cpu/x86/smm/smm_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/28347415_d8fd5da1 PS21, Line 54: #define setup_rmodule(mod , c) \ space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/eebbeb01_336ed3b4 PS21, Line 54: #define setup_rmodule(mod , c) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/02b680ad_cc401aa5 PS21, Line 59: hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; \ line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/0669d487_5e77860d PS21, Line 66: hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program; \ line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/d5c46b15_f39dade1 PS21, Line 80: /* hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; */ line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/b7db7659_1b1f4a88 PS21, Line 87: /* hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program ; */ line length of 105 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/7b8b5757_87fae774 PS21, Line 93: /* stub_module->program[i] = stub_string[i % sizeof(stub_string)]; */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/fef41d09_e0a73eda PS21, Line 106: hdr->payload_begin_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module; line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/d641275d_65b3952d PS21, Line 107: hdr->payload_end_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module + sizeof(handler_module->program); line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150315): https://review.coreboot.org/c/coreboot/+/63560/comment/8e5b90a5_7bc24a57 PS21, Line 113: hdr->parameters_begin = (uintptr_t)&handler_module->params - (uintptr_t)handler_module->program; line length of 104 exceeds 96 columns
-
build bot (Jenkins) (Code Review)