HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41514 )
Change subject: soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h> ......................................................................
soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h>
Change-Id: I6dd004b417c27ff0b9f7e55557a9670f927d425c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/xeon_sp/skx/soc_util.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/41514/1
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index aa965b6..dc97d5e 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <commonlib/sort.h> #include <console/console.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <delay.h> #include <device/pci.h>
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41514 )
Change subject: soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h> ......................................................................
Patch Set 1: Code-Review+1
Thanks!
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41514 )
Change subject: soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41514 )
Change subject: soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h> ......................................................................
soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h>
Change-Id: I6dd004b417c27ff0b9f7e55557a9670f927d425c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41514 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/xeon_sp/skx/soc_util.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jonathan Zhang: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index aa965b6..dc97d5e 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <commonlib/sort.h> #include <console/console.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <delay.h> #include <device/pci.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41514 )
Change subject: soc/intel/xeon_sp/skx/soc_util.c: Remove unused <cpu/cpu.h> ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4580 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4579 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4578 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4577
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Jonathan Zhang (Code Review)
-
Patrick Georgi (Code Review)