Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 )
Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c... PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1)
Sorry i945_setup_pci_express_x16() is the wrong function for the […]
I'm using i945_setup_pci_express_x16() for desktop version. ATI pcie card needs this function, but seems that nvidia don't (see https://review.coreboot.org/#/c/coreboot/+/27985/ comment in "Patch Set 3" ):
"Arthur Heymans - Aug 10 6:27 PM
Patch Set 3:
So from tests it looks like the datasheet is right when it says PEG and the IGD are mutually exclusive. The best thing to do is to make sure i945_setup_pci_express_x16() works fine for 945GC (iirc it messed up nvidia cards)"