Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37280 )
Change subject: soc/intel/fsp-car: Halt on improperly configured coreboot ......................................................................
soc/intel/fsp-car: Halt on improperly configured coreboot
Test if Kconfig symbols actually match what FSP does. If it is not the case it best to halt right away instead of continuing to boot with possibly hard to debug problems.
Change-Id: I8520adc868f08938af27ee686a8777c281afd4f9 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/37280/1
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S index 4174f36..bde3849 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S @@ -86,6 +86,11 @@ cmp $0, %eax jnz .halt_forever
+ /* Check sanity of coreboot Kconfig symbols that need to match what FSP + does */ + cmpl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %edx + jne .halt_forever + /* Setup bootblock stack */ movl _ecar_stack, %esp
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37280 )
Change subject: soc/intel/fsp-car: Halt on improperly configured coreboot ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37280/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37280/2//COMMIT_MSG@9 PS2, Line 9: If it is not : the case it best maybe: `Otherwise, it is best`
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37280 )
Change subject: soc/intel/fsp-car: Halt on improperly configured coreboot ......................................................................
Abandoned
Halting in assembly before attempting console startup is bad.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)