Attention is currently required from: Robert Zieba, Raul Rangel, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69914 )
Change subject: device/xhci: Refactor functions to work with a non-const device tree
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69914/comment/2d1b986d_e335561b
PS4, Line 7: non-const
const?
File src/device/xhci_const.c:
https://review.coreboot.org/c/coreboot/+/69914/comment/8ccd7d06_066874ae
PS4, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
Isn't this filename backwards? Isn't this the non-const file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5a74f9529d5dc6031ec968ef5f40a9cad5ffbc4
Gerrit-Change-Number: 69914
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 21:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment