Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Rizwan Qureshi, EricR Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55349 )
Change subject: mb/google/brya: Configure SIM detect GPIO with 20k pull up
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55349/comment/b9d15723_ea401f96
PS1, Line 7: 20k pull up
Can you please add the motivation behind why this is required?
Done
https://review.coreboot.org/c/coreboot/+/55349/comment/cac2a235_32101b44
PS1, Line 8:
Please mention the source, for example schematics.
Done
Patchset:
PS1:
I think we will remove this pin in P2?
Yes, Eric this will be removed, since P2 build will take some time to arrive physically, need this patch to unblock the WWAN enablement
File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/55349/comment/90e0d64f_ffcc3b14
PS1, Line 249: GPP_F19
This SIM detect pin was never meant to be connected to the PCH, but it is, and it's also missing a p […]
Can we configure F19 with Pull up and remove it when we have P2 boards ?
I believe it will take some time to get P2 boards
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e972f4b24a04184e7fc9bddf2a146abbe85b926
Gerrit-Change-Number: 55349
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 15 Jun 2021 08:02:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment