Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74717?usp=email )
Change subject: soc/amd/common/data_fabric/domain: provide scan_bus and read_resources
......................................................................
Patch Set 13: Code-Review+1
(4 comments)
Patchset:
PS13:
Didn't compare with what _fill_ssdt does, yet.
File src/soc/amd/common/block/data_fabric/Kconfig:
https://review.coreboot.org/c/coreboot/+/74717/comment/2ba86120_af56450a :
PS13, Line 13: ist
*it*
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/74717/comment/c8803f0f_028b9c9c :
PS12, Line 39: D18F0_MMIO_SHIFT
Couldn't find a register description any public doc about it?
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/74717/comment/a6186fad_baa7ff7f :
PS13, Line 77: dev
If we expect `dev` always to be a domain device, maybe call it `domain`. Same below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aada7c8a2a43145ad08d11d0a38d9cdc182b98e
Gerrit-Change-Number: 74717
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Jun 2023 17:09:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment