Attention is currently required from: Shelley Chen, Ravi kumar, Sandeep Maheswaram.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55378 )
Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN
......................................................................
Patch Set 43:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55378/comment/a2cba394_215b1805
PS42, Line 23: /* Assert EN_PP3300_HUB for those board variants that use it. */
: if (CONFIG(BOARD_GOOGLE_HEROBRINE)) {
: gpio_output(USB_HUB_LDO_EN, 1);
: } else {
: gpio_output(USB_HUB_LDO_EN, 1);
: }
:
This condition doesn't seem necessary anymore since the if and else conditions are exactly the same.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2
Gerrit-Change-Number: 55378
Gerrit-PatchSet: 43
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Sandeep Maheswaram
sanm@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sandeep Maheswaram
sanm@codeaurora.org
Gerrit-Comment-Date: Wed, 03 Nov 2021 00:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment