Change in coreboot[master]: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h

[Ronak Kanabar (Code Review)]

Attention is currently required from: Nico Huber, Maulik V Vaghela, Paul Menzel, Subrata Banik, Aamir Bohra.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )

Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h
......................................................................

Patch Set 12:

(2 comments)

File src/drivers/intel/fsp2_0/hand_off_block.c:

https://review.coreboot.org/c/coreboot/+/45905/comment/e33d7206_0da4d6a1 
PS12, Line 212: #if CONFIG(DISPLAY_FSP_VERSION_INFO) || CONFIG(DISPLAY_FSP_VERSION_INFO_2)
> do we really need a guard here?

if someone/some platform  will not select any of the config.

below code will prompt compilation error. code from line number 241

https://review.coreboot.org/c/coreboot/+/45905/comment/9cb5af09_819bcded 
PS12, Line 226: #elif
> just #if CONFIG(DISPLAY_FSP_VERSION_INFO_2) won't work ?

both can work

#endif
#if CONFIG(DISPLAY_FSP_VERSION_INFO_2)

or

#elif CONFIG(DISPLAY_FSP_VERSION_INFO_2)

so i went for elif

do you think we should use only #if ?