Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80850?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for touchpanel
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/gothrax/gpio.c:
https://review.coreboot.org/c/coreboot/+/80850/comment/46804098_09b97228 :
PS1, Line 83: nontp
nit: tp_disable?
We plan not to set up these GPP_C0/GPP_C1 without a touch screen.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80850?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23c62406a932815ff1cfafe05b70468b1f9cca54
Gerrit-Change-Number: 80850
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 01 Mar 2024 08:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment