build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 )
Change subject: cpu/intel/speedstep: Add Netburst CPUs ......................................................................
Patch Set 38:
(4 comments)
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c@48 PS38, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c:
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c... PS38, Line 38: ((c.x86 == 6 && c.x86_model == 0x17) ? SPEEDSTEP_RATIO_NONINT : 0) line over 80 characters
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c... PS38, Line 110: } code indent should use tabs where possible
https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c... PS38, Line 110: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)