Change in coreboot[master]: ec/google/chromeec: Add more wrappers for regulator control

[Yidi Lin (Code Review)]

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

ec/google/chromeec: Add more wrappers for regulator control

google_chromeec_regulator_enable is for enabling/disabling
the regulator.
google_chromeec_regulator_is_enabled is for querying if the
regulator is enabled.

BUG=b:168863056,b:147789962
BRANCH=none
TEST=emerge-asurada coreboot

Signed-off-by: Yidi Lin 
Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 63 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46686/1

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 39cf895..ec32df0 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -1617,6 +1617,53 @@
    return 0;
 }

+int google_chromeec_regulator_enable(uint32_t index, uint8_t enable)
+{
+	struct ec_params_regulator_enable params = {
+		.index = index,
+		.enable = enable,
+	};
+	struct chromeec_command cmd = {
+		.cmd_code = EC_CMD_REGULATOR_ENABLE,
+		.cmd_version = 0,
+		.cmd_data_in = &params,
+		.cmd_size_in = sizeof(params),
+		.cmd_data_out = NULL,
+		.cmd_size_out = 0,
+		.cmd_dev_index = 0,
+	};
+
+	if (google_chromeec_command(&cmd))
+		return -1;
+
+	return 0;
+}
+
+int google_chromeec_regulator_is_enabled(uint32_t index, uint8_t *enabled)
+{
+
+	struct ec_params_regulator_is_enabled params = {
+		.index = index,
+	};
+	struct ec_response_regulator_is_enabled resp = {};
+	struct chromeec_command cmd = {
+		.cmd_code = EC_CMD_REGULATOR_IS_ENABLED,
+		.cmd_version = 0,
+		.cmd_data_in = &params,
+		.cmd_size_in = sizeof(params),
+		.cmd_data_out = &resp,
+		.cmd_size_out = sizeof(resp),
+		.cmd_dev_index = 0,
+	};
+
+	if (google_chromeec_command(&cmd))
+		return -1;
+
+	*enabled = resp.enabled;
+
+	return 0;
+}
+
 int google_chromeec_regulator_set_voltage(uint32_t index, uint32_t min_mv,
    				  uint32_t max_mv)
 {
diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index c2ceff8..f081b89 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -354,6 +354,22 @@
 int google_chromeec_ap_reset(void);

/**
+ * Configure the regulator as enabled / disabled.
+ * @param index		Regulator ID
+ * @param enable	Set to enable / disable the regulator
+ * @return		0 on success, -1 on error
+ */
+int google_chromeec_regulator_enable(uint32_t index, uint8_t enable);
+
+/**
+ * Query if the regulator is enabled.
+ * @param index		Regulator ID
+ * @param *enabled	If successful, enabled indicates enable/disable status.
+ * @return		0 on success, -1 on error
+ */
+int google_chromeec_regulator_is_enabled(uint32_t index, uint8_t *enabled);
+
+/**
  * Set voltage for the voltage regulator within the range specified.
  * @param index		Regulator ID
  * @param min_mv	Minimum voltage

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h 
File src/ec/google/chromeec/ec.h:

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h... 
PS1, Line 358:  * @param index		Regulator ID
One blank line before parameter list.

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h... 
PS1, Line 365:  * Query if the regulator is enabled.
One blank line before parameter list.

[Yidi Lin (Code Review)]

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46686

to look at the new patch set (#2).

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

ec/google/chromeec: Add more wrappers for regulator control

google_chromeec_regulator_enable is for enabling/disabling
the regulator.
google_chromeec_regulator_is_enabled is for querying if the
regulator is enabled.

BUG=b:168863056,b:147789962
BRANCH=none
TEST=emerge-asurada coreboot

Signed-off-by: Yidi Lin 
Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 67 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46686/2

[Yidi Lin (Code Review)]

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h 
File src/ec/google/chromeec/ec.h:

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h... 
PS1, Line 358:  * @param index		Regulator ID
> One blank line before parameter list.

Ack

https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h... 
PS1, Line 365:  * Query if the regulator is enabled.
> One blank line before parameter list.

Ack

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46686/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46686/2//COMMIT_MSG@11 
PS2, Line 11: google_chromeec_regulator_is_enabled
Move it to the previous line (I think ti will be less than 72 characters).

[Yidi Lin (Code Review)]

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46686

to look at the new patch set (#3).

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

ec/google/chromeec: Add more wrappers for regulator control

google_chromeec_regulator_enable is for enabling/disabling
the regulator. google_chromeec_regulator_is_enabled is for
querying if the regulator is enabled.

BUG=b:168863056,b:147789962
BRANCH=none
TEST=emerge-asurada coreboot

Signed-off-by: Yidi Lin 
Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 67 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46686/3

[Yidi Lin (Code Review)]

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46686/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46686/2//COMMIT_MSG@11 
PS2, Line 11: google_chromeec_regulator_is_enabled
> Move it to the previous line (I think ti will be less than 72 characters).

Ack

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

Patch Set 4: Code-Review+2

[Yidi Lin (Code Review)]

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46686

to look at the new patch set (#8).

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

ec/google/chromeec: Add more wrappers for regulator control

google_chromeec_regulator_enable is for enabling/disabling
the regulator. google_chromeec_regulator_is_enabled is for
querying if the regulator is enabled.

BUG=b:168863056,b:147789962
BRANCH=none
TEST=emerge-asurada coreboot

Signed-off-by: Yidi Lin 
Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 67 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46686/8

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46686 )

Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................

ec/google/chromeec: Add more wrappers for regulator control

google_chromeec_regulator_enable is for enabling/disabling
the regulator. google_chromeec_regulator_is_enabled is for
querying if the regulator is enabled.

BUG=b:168863056,b:147789962
BRANCH=none
TEST=emerge-asurada coreboot

Signed-off-by: Yidi Lin 
Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46686
Tested-by: build bot (Jenkins) 
Reviewed-by: Yu-Ping Wu 
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 67 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Yu-Ping Wu: Looks good to me, approved

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 2ffccbc7..ed7f97d 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -1624,6 +1624,53 @@
    return 0;
 }

+int google_chromeec_regulator_enable(uint32_t index, uint8_t enable)
+{
+	struct ec_params_regulator_enable params = {
+		.index = index,
+		.enable = enable,
+	};
+	struct chromeec_command cmd = {
+		.cmd_code = EC_CMD_REGULATOR_ENABLE,
+		.cmd_version = 0,
+		.cmd_data_in = &params,
+		.cmd_size_in = sizeof(params),
+		.cmd_data_out = NULL,
+		.cmd_size_out = 0,
+		.cmd_dev_index = 0,
+	};
+
+	if (google_chromeec_command(&cmd))
+		return -1;
+
+	return 0;
+}
+
+int google_chromeec_regulator_is_enabled(uint32_t index, uint8_t *enabled)
+{
+
+	struct ec_params_regulator_is_enabled params = {
+		.index = index,
+	};
+	struct ec_response_regulator_is_enabled resp = {};
+	struct chromeec_command cmd = {
+		.cmd_code = EC_CMD_REGULATOR_IS_ENABLED,
+		.cmd_version = 0,
+		.cmd_data_in = &params,
+		.cmd_size_in = sizeof(params),
+		.cmd_data_out = &resp,
+		.cmd_size_out = sizeof(resp),
+		.cmd_dev_index = 0,
+	};
+
+	if (google_chromeec_command(&cmd))
+		return -1;
+
+	*enabled = resp.enabled;
+
+	return 0;
+}
+
 int google_chromeec_regulator_set_voltage(uint32_t index, uint32_t min_mv,
    				  uint32_t max_mv)
 {
diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index bed8594..c3c456f 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -354,7 +354,26 @@
 int google_chromeec_ap_reset(void);

/**
+ * Configure the regulator as enabled / disabled.
+ *
+ * @param index		Regulator ID
+ * @param enable	Set to enable / disable the regulator
+ * @return		0 on success, -1 on error
+ */
+int google_chromeec_regulator_enable(uint32_t index, uint8_t enable);
+
+/**
+ * Query if the regulator is enabled.
+ *
+ * @param index		Regulator ID
+ * @param *enabled	If successful, enabled indicates enable/disable status.
+ * @return		0 on success, -1 on error
+ */
+int google_chromeec_regulator_is_enabled(uint32_t index, uint8_t *enabled);
+
+/**
  * Set voltage for the voltage regulator within the range specified.
+ *
  * @param index		Regulator ID
  * @param min_mv	Minimum voltage
  * @param max_mv	Maximum voltage
@@ -365,6 +384,7 @@

/**
  * Get the currently configured voltage for the voltage regulator.
+ *
  * @param index		Regulator ID
  * @param *voltage_mv	If successful, voltage_mv is filled with current voltage
  * @return		0 on success, -1 on error