[M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM

[Paul Menzel (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, agogo.

Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: soc/mediatek/mt8196: Initialize MCUPM
......................................................................

Patch Set 8:

(3 comments)

File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:

https://review.coreboot.org/c/coreboot/+/85888/comment/64abfd3a_26c9d012?usp... :
PS6, Line 69: POLLING_MCU_TIME
> Done

Maybe `POLLING_MCU_RETRY_COUNT`?

File src/soc/mediatek/mt8196/mcupm.c:

https://review.coreboot.org/c/coreboot/+/85888/comment/9c3e9910_86c2dca4?usp... :
PS6, Line 17: POLLING_MCU_TIME
> Done

Yes, the usage is correct but it’s unintuitive in this case.

https://review.coreboot.org/c/coreboot/+/85888/comment/e71c4841_d67b80c3?usp... :
PS6, Line 21: 		       "[EB_SPMC] Polling MCU_PORT_SET_R0_0 timeout, %#x\n",
> Done

I meant the limit (which equals the tries). Currently, getting this message, I’d have to open two files to find out how many times it was tried.

Also the error message is not correct to my understanding. Polling the register worked but neither of two bits indicating CPUEB(?) is ready is set.