Attention is currently required from: Arthur Heymans, Sean Rhodes.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79669?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: device/Kconfig: Move Intel/ACPI/USB4 specific Kconfig options
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/usb4/Kconfig:
https://review.coreboot.org/c/coreboot/+/79669/comment/317633b0_75746f77 :
PS3, Line 38: d
Shouldn't this just be an if around everything in this file except `config SOC_INTEL_COMMON_BLOCK_USB4`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79669?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia515d52baead9e151533278c33fda9436ee56168
Gerrit-Change-Number: 79669
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 14 Jan 2024 02:01:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment