Attention is currently required from: Kapil Porwal, Paul Menzel, Pranava Y N.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84297?usp=email )
Change subject: soc/intel/ptl: Add GPE1 defines
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84297/comment/e9e1c6e0_84be7ad0?usp... :
PS9, Line 7: Add GPE1 defines
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/84297/comment/70914e11_ada21f20?usp... :
PS9, Line 9: defines for GPE number for additional STD GPE0 in PTL
: defines for GPE number for GPE1
: defines for GPE1 bits
Please elaborate more before this is submitted.
Done
https://review.coreboot.org/c/coreboot/+/84297/comment/6707ec2c_00cc2f5b?usp... :
PS9, Line 12: STD
STD GPE have been used for Intel's GPE bits in this case. I can add more here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84297?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebf6f6d02b37cc9702e4ee07c1ec0017b6628836
Gerrit-Change-Number: 84297
Gerrit-PatchSet: 9
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 16 Sep 2024 19:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org