Change in coreboot[master]: chromeos: Provide common watchdog reboot support in romstage

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

9 Sep 2020 9 Sep '20

6:05 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45213 )

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

chromeos: Provide common watchdog reboot support in romstage

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 --- M src/vendorcode/google/chromeos/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45213/1

diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc index b429d6b..927b90b 100644 --- a/src/vendorcode/google/chromeos/Makefile.inc +++ b/src/vendorcode/google/chromeos/Makefile.inc @@ -15,3 +15,4 @@ bootblock-y += watchdog.c verstage-y += watchdog.c ramstage-y += watchdog.c +romstage-y += watchdog.c

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Julius Werner (Code Review)

9 Sep 9 Sep

10:07 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45213 )

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... PS3, Line 18: romstage-y += watchdog.c This patch needs to be reordered before the others so that mark_watchdog_tombstone() is already available in the patch that adds a call to it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Gerrit-Change-Number: 45213 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 10 Sep 2020 01:07:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi kumar (Code Review)

14 Sep 14 Sep

1:39 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney, Julius Werner, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45213

to look at the new patch set (#5).

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

chromeos: Provide common watchdog reboot support in romstage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45213/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/45213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Gerrit-Change-Number: 45213 Gerrit-PatchSet: 5 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

10:08 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45213 )

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... PS3, Line 18: romstage-y += watchdog.c

...

This patch needs to be reordered before the others so that mark_watchdog_tombstone() is already avai […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Gerrit-Change-Number: 45213 Gerrit-PatchSet: 6 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 15 Sep 2020 01:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Julius Werner (Code Review)

10:09 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45213 )

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Gerrit-Change-Number: 45213 Gerrit-PatchSet: 6 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 15 Sep 2020 01:09:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

10:09 p.m.

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45213 )

Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................

chromeos: Provide common watchdog reboot support in romstage

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45213 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/google/chromeos/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc index b429d6b..e17236d 100644 --- a/src/vendorcode/google/chromeos/Makefile.inc +++ b/src/vendorcode/google/chromeos/Makefile.inc @@ -14,4 +14,5 @@

bootblock-y += watchdog.c verstage-y += watchdog.c +romstage-y += watchdog.c ramstage-y += watchdog.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/45213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3 Gerrit-Change-Number: 45213 Gerrit-PatchSet: 7 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

1680

days inactive

1686

days old

coreboot-gerrit@coreboot.org

5 comments

2 participants

tags (0)

participants (2)

Julius Werner (Code Review)
Ravi kumar (Code Review)