Attention is currently required from: Maciej Pijanowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer, Michal Zygowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake ......................................................................
Patch Set 17:
(21 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73934/comment/9beb322b_7451f6ea PS4, Line 11: Document Number: 618876
Corrected, in current commit (Patchset #9)
Ack
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/d85f26e4_60c92e0f PS17, Line 15: "ESPI_RESET,_N", "ESPI_RESET_N"
https://review.coreboot.org/c/coreboot/+/73934/comment/2efead11_eb905683 PS17, Line 18: "SMB_ALERT_,N", "SMB_ALERT_N"
https://review.coreboot.org/c/coreboot/+/73934/comment/83ef1e42_636acd07 PS17, Line 148: "GPP_L_BKLTEN", "GPP_L_BKLTEN", : "GPP_L_BKLTCTL", "GPP_L_BKLTCTL", : "GPP_LVDDEN", "GPP_LVDDEN", : "GPP_SYS_PWROK", "GPP_SYS_PWROK", : "GPP_SYS_RESETB", "GPP_SYS_RESETB", : "GPP_MLK_RSTB", "GPP_MLK_RSTB", These pins should not have GPP_ prefix
https://review.coreboot.org/c/coreboot/+/73934/comment/b2fbd389_857656fd PS17, Line 157: GPP_HVCMOS Just HVCMOS
https://review.coreboot.org/c/coreboot/+/73934/comment/9b0eb9eb_84eb3c1e PS17, Line 503: const char *const jasperlake_pch_group_vgpio_padding_names [] ={ Just jasperlake_pch_group_vgpio_names and jasperlake_pch_group_vgpio
Here and everywhere for this group
https://review.coreboot.org/c/coreboot/+/73934/comment/85ccf103_c21c61d9 PS17, Line 554: "GPD_INPUT3VSEL", "GPD_INPUT3VSEL", : "GPD_SLP_SUSB", "GPD_SLP_SUSB", : "GPD_WAKEB", "GPD_WAKEB", : "GPD_DRAM_RESETB", "GPD_DRAM_RESETB", These should not have GPD_ prefix
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/5ae00834_1dd0a4c2 PS12, Line 539: // Deep Sleep Well group
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/7bbd8c7c_bd7f9389 PS12, Line 553: "GPD_INPUT3VSEL", "GPD_INPUT3VSEL",
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/13179688_8439233f PS12, Line 584:
Done
Ack
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/879a1884_81233b37 PS4, Line 141: "L_BLKTEN", : "L_BLKTCTL", : "LVDDEN", : "SYS_PWROK", : "SYS_RESETB", : "MLK_RSTB",
Corrected, in Patchset #8
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/9e852f0e_46657d1a PS4, Line 191: "JTAG_TD0", : "JTAGX", : "PRDYB", : "PREQB", : "CPU_TRSTB", : "JTAG_TDI", : "JTAG_TMS", : "JTAG_TCK", : "ITP_PMODE"
Corrected, in patchset #8
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/5dd092da_c53db664 PS4, Line 266: "GPP_H15", "AVS_I2S1_SCLK", "n/a", "n/a",
Ack, corrected in my working copy, will be visible after pushing.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/266442d8_6cf6ba51 PS4, Line 281: "GSPI2_CLK_LOOPBK", : "SPI1_CLK_LOOPBK",
Corrected, in patchset #9.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/db40cd9a_309c53ce PS4, Line 312: "GSPI0_CLK_LOOPBK", : "GSPI1_CLK_LOOPBK",
Corrected, in patchset #9.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/c383184e_45c577d5 PS4, Line 336: .pad_count = ARRAY_SIZE(jasperlake_pch_group_r_names) / 6, : .func_count = 6,
Corrected.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/f9666043_ecf35e05 PS4, Line 354: .pad_count = ARRAY_SIZE(jasperlake_pch_group_s_names) / 2, : .func_count = 2,
Corrected.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/952fa78e_c8707db9 PS4, Line 361: "HDACPU_SDI", : "HDACPU_SDO", : "HDACPU_SCLK", : "PM_SYNC", : "PECI", : "CPUPWRGD", : "THRMTRIPB", : "PLTRST_CPUB", : "PM_DOWN", : "TRIGGER_IN", : "TRIGGER_OUT", : "UFS_RESETB", : "CLKOUT_CPURTC", : "VCCST_PWRGD", : "C10_WAKE",
Corrected.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/d1453600_6dd7cbf3 PS4, Line 386: "VGPIO_PCIE0", : "VGPIO_PCIE1", : "VGPIO_PCIE2", : "VGPIO_PCIE3", : "VGPIO_PCIE4", : "VGPIO_PCIE5", : "VGPIO_PCIE6", : "VGPIO_PCIE7", : "VGPIO_PCIE8", : "VGPIO_PCIE9", : "VGPIO_PCIE10", : "VGPIO_PCIE11", : "VGPIO_PCIE12", : "VGPIO_PCIE13", : "VGPIO_PCIE14", : "VGPIO_PCIE15", : "VGPIO_PCIE16", : "VGPIO_PCIE17", : "VGPIO_PCIE18", : "VGPIO_PCIE19", : "VGPIO_PCIE20", : "VGPIO_PCIE21", : "VGPIO_PCIE22", : "VGPIO_PCIE23", : "VGPIO_PCIE24", : "VGPIO_PCIE25", : "VGPIO_PCIE26", : "VGPIO_PCIE27", : "VGPIO_PCIE28", : "VGPIO_PCIE29", : "VGPIO_PCIE30", : "VGPIO_PCIE31", : "VGPIO_PCIE32", : "VGPIO_PCIE33", : "VGPIO_PCIE34", : "VGPIO_PCIE35", : "VGPIO_PCIE36", : "VGPIO_PCIE37", : "VGPIO_PCIE38", : "VGPIO_PCIE39", : "VGPIO_PCIE40", : "VGPIO_PCIE41", : "VGPIO_PCIE42", : "VGPIO_PCIE43", : "VGPIO_PCIE44", : "VGPIO_PCIE45", : "VGPIO_PCIE46", : "VGPIO_PCIE47", : "VGPIO_PCIE48", : "VGPIO_PCIE49", : "VGPIO_PCIE50", : "VGPIO_PCIE51", : "VGPIO_PCIE52", : "VGPIO_PCIE53", : "VGPIO_PCIE54", : "VGPIO_PCIE55", : "VGPIO_PCIE56", : "VGPIO_PCIE57", : "VGPIO_PCIE58", : "VGPIO_PCIE59", : "VGPIO_PCIE60", : "VGPIO_PCIE61", : "VGPIO_PCIE62", : "VGPIO_PCIE63", : "VGPIO_PCIE64", : "VGPIO_PCIE65", : "VGPIO_PCIE66", : "VGPIO_PCIE67", : "VGPIO_PCIE68", : "VGPIO_PCIE69", : "VGPIO_PCIE70", : "VGPIO_PCIE71", : "VGPIO_PCIE72", : "VGPIO_PCIE73", : "VGPIO_PCIE74", : "VGPIO_PCIE75", : "VGPIO_PCIE76", : "VGPIO_PCIE77", : "VGPIO_PCIE78", : "VGPIO_PCIE79",
Corrected.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/dddfa0f6_65474fbe PS4, Line 475: "VGPIO_USB0", : "VGPIO_USB1", : "VGPIO_USB2", : "VGPIO_USB3", : "VGPIO_USB4", : "VGPIO_USB5", : "VGPIO_USB6", : "VGPIO_USB7", : "VGPIO_USB8", : "VGPIO_USB9", : "VGPIO_USB10", : "VGPIO_USB11",
Corrected.
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/4c4231a6_9760e8bc PS4, Line 511: const struct gpio_group jasperlake_pch_group_dsw = { : .display = "------- GPIO Group GPP_S -------", : .pad_count = ARRAY_SIZE(jasperlake_pch_group_dsw_names) / 2, : .func_count = 2, : .pad_names = jasperlake_pch_group_s_names, : }; : : const struct gpio_group jasperlake_pch_group_vgpio_pcie = { : .display = "------- GPIO Group GPP_S -------", : .pad_count = ARRAY_SIZE(jasperlake_pch_group_dsw_names) / 2, : .func_count = 2, : .pad_names = jasperlake_pch_group_s_names, : };
Two GPP_S groups, both using jasperlake_pch_group_dsw_names and jasperlake_pch_group_s_names and nam […]
Ack
-
Michał Żygowski (Code Review)