Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Nick Vaccaro.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63750 )
Change subject: soc/intel/common: Add Raptor Lake device IDs
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63750/comment/15cf8103_b1999c67
PS2, Line 7: soc/intel/common: Add Raptor Lake device IDs
Considering the wideness of this patch, I believe `soc/intel` as the header prefix is more appropriate.
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/63750/comment/fffeb297_10fb4170
PS1, Line 62: #define CPUID_RAPTORLAKE_J0 0xb06a2
I followed the naming convention but CPUID_RAPTORLAKE_P_J0 maybe good idea. […]
Which naming convention are you referring to ? I am under the impression other definition preceding this one also include a SKU letter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39e655dec2314a672ea63ba90d8bb3fc53bf77ba
Gerrit-Change-Number: 63750
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 17:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment