Attention is currently required from: Andy Pont, Tim Wawrzynczak. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support ......................................................................
Patch Set 12:
(3 comments)
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52797/comment/8cb6a381_1c7739fb PS12, Line 373: : // Method(_Q45) // SMM Mode - Not used in coreboot : // { : // SMB2 = 0xC1 : // }
remove?
Plan to use it in the future - hence it being left
File src/ec/starlabs/it8987/acpi/hid.asl:
PS12:
just in general, why keep all of these commented-out lines?
Reminder of the original source I guess. It's been happy for months now so it can go.
https://review.coreboot.org/c/coreboot/+/52797/comment/2f311446_996405b4 PS12, Line 16: // If (((OSYS >= 0x07DD) && (HEFE == One)))
remove?
Removed