Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Hannah Williams, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29394
to look at the new patch set (#13).
Change subject: {src/include},{soc/intel): Configure HDA codecs ......................................................................
{src/include},{soc/intel): Configure HDA codecs
HDA support did not configure the codecs correclty. Use Intel common block support to configure the codecs.
To use common Intel HDA support file hda.c file has been removed and Braswell HDA device ID is added to list of supported PCI devices in intel/common/block/hda/hda.c.
CONFIG_SOC_INTEL_COMMON_BLOCK and CONFIG_SOC_INTEL_COMMON_BLOCK_HDA are enabled to include hda.c in build.
When codec table is available at board level SOC_INTEL_COMMON_BLOCK_HDA_VERB must be enabled and a codec table must be supplied.
BUG=N/A TEST=Facebook FBG-1701 ALC298 configuration
Change-Id: I5c23ec311e5b5a6dfd6f031aa19617407fe8ed63 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/include/device/pci_ids.h M src/soc/intel/braswell/Kconfig M src/soc/intel/braswell/Makefile.inc D src/soc/intel/braswell/hda.c M src/soc/intel/common/block/hda/hda.c 5 files changed, 5 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/29394/13