Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63953 )
Change subject: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/63953/comment/ea8c9db1_bce257d6
PS2, Line 801: printk(BIOS_ERR, "PMC: Failed sending PCI Enumeration Done Command\n");
As you have the response handy here, would it make sense to show the reason for this command being failed? Or is it just another magic bitfield with no proper decoding?
Unfortunately, it's the latter one where the response bit field is not documented hence, had to relying on status instead parsing than actual response.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77d428f9501feaccab8bb431090d10ce8d3af9b2
Gerrit-Change-Number: 63953
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 02 May 2022 18:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment