Change in coreboot[master]: soc/intel/tigerlake: Add code for early tcss

[caveh jalali (Code Review)]

caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )

Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................

Patch Set 30:

(5 comments)

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
File src/soc/intel/tigerlake/early_tcss.c:

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
PS30, Line 24: uint8_t
cosnt...

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
PS30, Line 27: malloc
do we really need to malloc 16 bytes?
where's the free?

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
PS30, Line 27: wbuf
we should probably zero out the buffer so we don't have
unpredictable values getting copied into the unused
portion of PMC_IPC_WBUF*

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
PS30, Line 39: 8
PMC_IPC_CONN_REQ_SIZE

https://review.coreboot.org/c/coreboot/+/37870/30/src/soc/intel/tigerlake/ea... 
PS30, Line 51: printk(BIOS_DEBUG, "tcss_req[0]-> 0x%x\n"
             : 		"tcss_req[1]-> 0x%x\n\t", tcss_req[0], tcss_req[1]);
             : 
move all of these prints to send_ipc_command?