Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Patrick Rudolph. Timofey Komarov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Add Kconfig option for LGA1151v2 ......................................................................
Patch Set 9:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/c4d67bf7_7b851505 PS5, Line 7: to use
AFAIK, "allow to use" is correct. Google says it's much more popular, too: […]
Ack
https://review.coreboot.org/c/coreboot/+/52692/comment/4912400e_12c7a83c PS5, Line 7: to use
AFAIK, "allow to use" is correct. Google says it's much more popular, too: […]
Ack
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/651a6a7e_647112a0 PS5, Line 95: default 16 if MAINBOARD_SUPPORTS_COFFEELAKE_CPU
Alternatively, keep it in this change, but adapt the commit message; […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/99ed9287_25421fea PS5, Line 256: # SkylakeFsp is FSP 1.1 and therefore incompatible.
Why move the comment?
Because it's not only about FSP_HEADER_PATH, but also about FSP_FD_PATH
https://review.coreboot.org/c/coreboot/+/52692/comment/51c87d6c_85d9baf9 PS5, Line 259: if SOC_INTEL_SKYLAKE_LGA1151_V2
No need to break the line, this fits in 96 characters
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/5b430977_794dcf6e PS5, Line 264: if SOC_INTEL_SKYLAKE_LGA1151_V2
No need to break the line, this fits in 96 characters
Done
-
Timofey Komarov (Code Review)