Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54084 )
Change subject: mb/google/guybrush,mancomb: select GOOGLE_SMBIOS_MAINBOARD_VERSION ......................................................................
mb/google/guybrush,mancomb: select GOOGLE_SMBIOS_MAINBOARD_VERSION
Select GOOGLE_SMBIOS_MAINBOARD_VERSION allows querying board revision from the EC.
BUG=b:187904819 TEST=1. emerge-guybrush coreboot chromeos-bootimage 2. flash the image to the device and check board rev by using command `dmidecode -t 1 | grep Version`
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I48dc83d85cfc49e2e4155e389814fce08693c4bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/54084 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Peers epeers@google.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/mancomb/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Eric Peers: Looks good to me, but someone else must approve Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 9a69dd0..fc515af 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -24,6 +24,7 @@ select ELOG select ELOG_GSMI select FW_CONFIG + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_EM100_SUPPORT select HAVE_SPD_IN_CBFS diff --git a/src/mainboard/google/mancomb/Kconfig b/src/mainboard/google/mancomb/Kconfig index 91ec169..938382e 100644 --- a/src/mainboard/google/mancomb/Kconfig +++ b/src/mainboard/google/mancomb/Kconfig @@ -21,6 +21,7 @@ select ELOG select ELOG_GSMI select FW_CONFIG + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_EM100_SUPPORT select MAINBOARD_HAS_CHROMEOS