Change in coreboot[master]: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44927 )

Change subject: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'
......................................................................

mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'

GENERATE_SMBIOS_TABLES is already set to yes at src/Kconfig

Change-Id: I2845f4f329283360a49ea40dfee7d9a232ab4ea1
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/intel/tglrvp/Kconfig
M src/mainboard/supermicro/x11-lga1151-series/Kconfig
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44927/1

diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig
index 3e55f56..437f5c6 100644
--- a/src/mainboard/intel/tglrvp/Kconfig
+++ b/src/mainboard/intel/tglrvp/Kconfig
@@ -12,7 +12,6 @@
    select DRIVERS_INTEL_PMC
    select DRIVERS_USB_ACPI
    select DRIVERS_SPI_ACPI
-	select GENERATE_SMBIOS_TABLES
    select SOC_INTEL_TIGERLAKE
    select INTEL_LPSS_UART_FOR_CONSOLE
    select DRIVERS_INTEL_ISH
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig
index e23da43..a446835 100644
--- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig
+++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig
@@ -10,7 +10,6 @@
    select MAINBOARD_HAS_LPC_TPM
    select DRIVERS_ASPEED_AST2050
    select SUPERIO_ASPEED_AST2400
-	select GENERATE_SMBIOS_TABLES
    select IPMI_KCS
    select MAINBOARD_NO_FSP_GOP
    select SUPERIO_ASPEED_HAS_UART_DELAY_WORKAROUND

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44927

to look at the new patch set (#2).

Change subject: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'
......................................................................

mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'

GENERATE_SMBIOS_TABLES is already set to yes at src/Kconfig

Change-Id: I2845f4f329283360a49ea40dfee7d9a232ab4ea1
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/intel/tglrvp/Kconfig
M src/mainboard/supermicro/x11-lga1151-series/Kconfig
M src/mainboard/system76/lemp9/Kconfig
3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44927/2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44927 )

Change subject: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44927 )

Change subject: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'
......................................................................

mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'

GENERATE_SMBIOS_TABLES is already set to yes at src/Kconfig

Change-Id: I2845f4f329283360a49ea40dfee7d9a232ab4ea1
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44927
Tested-by: build bot (Jenkins) 
Reviewed-by: Michael Niewöhner
---
M src/mainboard/intel/tglrvp/Kconfig
M src/mainboard/supermicro/x11-lga1151-series/Kconfig
M src/mainboard/system76/lemp9/Kconfig
3 files changed, 0 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig
index 3e55f56..437f5c6 100644
--- a/src/mainboard/intel/tglrvp/Kconfig
+++ b/src/mainboard/intel/tglrvp/Kconfig
@@ -12,7 +12,6 @@
    select DRIVERS_INTEL_PMC
    select DRIVERS_USB_ACPI
    select DRIVERS_SPI_ACPI
-	select GENERATE_SMBIOS_TABLES
    select SOC_INTEL_TIGERLAKE
    select INTEL_LPSS_UART_FOR_CONSOLE
    select DRIVERS_INTEL_ISH
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig
index e23da43..a446835 100644
--- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig
+++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig
@@ -10,7 +10,6 @@
    select MAINBOARD_HAS_LPC_TPM
    select DRIVERS_ASPEED_AST2050
    select SUPERIO_ASPEED_AST2400
-	select GENERATE_SMBIOS_TABLES
    select IPMI_KCS
    select MAINBOARD_NO_FSP_GOP
    select SUPERIO_ASPEED_HAS_UART_DELAY_WORKAROUND
diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig
index 888b087..71f9fe5 100644
--- a/src/mainboard/system76/lemp9/Kconfig
+++ b/src/mainboard/system76/lemp9/Kconfig
@@ -5,7 +5,6 @@
    select BOARD_ROMSIZE_KB_16384
    select DRIVERS_INTEL_WIFI
    select EC_SYSTEM76_EC
-	select GENERATE_SMBIOS_TABLES
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select HAVE_SMI_HANDLER

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44927 )

Change subject: mb/*/Kconfig: Drop redundant 'select GENERATE_SMBIOS_TABLES'
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17519
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17518
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17517
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17516
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17515
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17522
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17521
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17520

Please note: This test is under development and might not be accurate at all!