Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 1:
(62 comments)
File src/mainboard/synology/ds918plus/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/7e250f8b_65661d59 PS1, Line 46: PAD_CFG_GPI_APIC_IOS(GPIO_33, DN_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/bc6b534a_424b3b03 PS1, Line 51: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/1ef1b94a_cf0c9cc6 PS1, Line 52: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/acd4d068_fc621d55 PS1, Line 53: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/9a24e889_8d185519 PS1, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/faa219bf_d00f4f4f PS1, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/6a838400_58021b43 PS1, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/0d2a7aaf_b2fd726f PS1, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART1_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/973bc67c_fddf403d PS1, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/cee6a6b0_05613ab4 PS1, Line 84: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_DT, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/2f0ee942_20e1898d PS1, Line 85: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_RSP, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/0feb1b10_ac8ac75e PS1, Line 101: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_193, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/0d541b3c_1047b736 PS1, Line 102: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_194, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/7862feed_f75a0785 PS1, Line 103: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_195, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/082fe262_690ea0e4 PS1, Line 113: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS0, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/a736c9ca_587d7da7 PS1, Line 114: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS1, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/c2fe66ed_cf813119 PS1, Line 116: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_RXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/751f9161_70b1c768 PS1, Line 117: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_TXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/702d84f1_ec11a0d8 PS1, Line 118: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_CLK, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/3f563c35_feb6d6a9 PS1, Line 120: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_RESET_B, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/cea3d006_e4ba1da6 PS1, Line 125: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_STDBY, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/046dbbc6_df16faa3 PS1, Line 136: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_81, DN_20K, DEEP, NF2, TxDRxE, ENPD), /* AVS_I2C4_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/386a01d2_e6ef9123 PS1, Line 138: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_83, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_DMIC_DATA_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/720317e2_1a11fc23 PS1, Line 146: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_91, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_I2S3_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/027d3538_b2095042 PS1, Line 156: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_104, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_CLK */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/2702d714_263b3d3a PS1, Line 157: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_105, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/38a4638b_899ddffa PS1, Line 158: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/cadeeb57_cc5f46de PS1, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_109, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/afb1182f_d5e9c73d PS1, Line 160: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/8260fd3f_47cd8aea PS1, Line 176: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_124, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/a74ff8dc_5dbb6d76 PS1, Line 177: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_125, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/ec14c41c_a826c589 PS1, Line 178: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/824a88df_f6aeef8c PS1, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/fba1498a_e2e942a3 PS1, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/652d174f_8519de2c PS1, Line 181: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/d57b99d9_13c770d4 PS1, Line 182: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/4dc57d2f_8c240200 PS1, Line 183: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/c9254899_5cae8086 PS1, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/a905134e_a05cb322 PS1, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/3c26f548_6f7444c0 PS1, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_134, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/0e1c7bf0_742635f9 PS1, Line 187: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_135, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/15ea26b7_3eeac536 PS1, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_136, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/940a6ef0_4c9baa27 PS1, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_137, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/0f7468e8_1ceaed03 PS1, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/561bbd62_1f129e93 PS1, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/72980f14_8e12b87f PS1, Line 202: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ0_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/8e012c12_b1b46fc5 PS1, Line 203: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/3b82c872_b33b67fd PS1, Line 204: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ2_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/3a72c944_f487de02 PS1, Line 205: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_212, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ3_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/96547f70_c1c2d9ac PS1, Line 215: PAD_CFG_NF_IOSTANDBY_IGNORE(PMU_RESETBUTTON_B, NONE, DEEP, NF1), /* PMU_RSTBTN_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/f611541c_f276eae6 PS1, Line 220: PAD_CFG_GPO_IOSSTATE_IOSTERM(PMU_WAKE_B, 1, DEEP, UP_20K, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/ccf5c3ec_d9a59d05 PS1, Line 263: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_CLKOUT1, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_CLKOUT1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/ea01020e_950c8c6a PS1, Line 264: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD0, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/dd88342c_a3c4209f PS1, Line 265: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD1, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/851b38a5_560722f9 PS1, Line 266: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD2, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/d61b269b_35a21173 PS1, Line 267: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD3, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/6bb9f03e_731d3dd2 PS1, Line 269: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_FRAMEB, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_FRAMEB */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/50741ec8_7eb5b28e PS1, Line 312: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/5f3bd8c2_b76d4254 PS1, Line 330: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/849c4a10_bc92f5c4 PS1, Line 331: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/69d3cd4a_e9126eef PS1, Line 332: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117530): https://review.coreboot.org/c/coreboot/+/52594/comment/e6ed9fc5_0230101f PS1, Line 333: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters