Attention is currently required from: cong yang, Jianeng Ceng, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74115 )
Change subject: mb/google/geralt: Power on Samsung ATNA33XC20 eDP panel
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74115/comment/93fa2273_bc420412
PS9, Line 2: cengjianeng
Please update your user name to not be the username.
$ git config --global user.name "Ceng …"
$ git commit --amend --author="Ceng … <…>" -s
https://review.coreboot.org/c/coreboot/+/74115/comment/b5922972_c81667da
PS9, Line 29: cengjianeng
Please update the spelling.
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/74115/comment/20bd42d9_80aa4f4f
PS9, Line 65: .name = "MUTTO_B152731E1",
Geralt is uses Samsung panel, and Mutto is responsible for bonding the panel and touch. […]
Thank you for the quick reply. Please mention that in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2d05c7eef1360ca954316f2e76b21ed1f85be8
Gerrit-Change-Number: 74115
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-MessageType: comment