Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35734 )
Change subject: intel/fsp_broadwell_de: Rename from xx_DEV_FUNC ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35734/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35734/1//COMMIT_MSG@7 PS1, Line 7: intel/fsp_broadwell_de: Rename from xx_DEV_FUNC
What is the reason for renaming?
Done
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell... PS1, Line 118: #define PCIE_PORT1_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT1_FUNC)
Deleting of these lines is not mentioned in comment
Done
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell... PS1, Line 53: #define PCH_DEVFN_VTD PCI_DEVFN(VTD_DEV, VTD_FUNC) PCH_, SCH_, something else for prefix?
-
Kyösti Mälkki (Code Review)