Attention is currently required from: Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 )
Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67027/comment/5b7a74c3_61216fa1
PS5, Line 88: device ref north_xhci on
Shouldn't this be the PCH one?
Done
https://review.coreboot.org/c/coreboot/+/67027/comment/0a40c5e6_3cd015cc
PS5, Line 110: device ref north_xdci on end
Why turn it on?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3
Gerrit-Change-Number: 67027
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Ben McMillen
ben@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment