Attention is currently required from: Stefan Ott, Furquan Shaikh, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55287 )
Change subject: drivers/generic/ioapic: Drop enable_virtual_wire
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/55287/comment/70f0d103_dc935c2f
PS5, Line 82: write_vector(ioapic_base, 0, high, low);
Looking at 7series / C216 doc 326776-003 […]
Anything to do?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie87816271fa63bba892c8615aa5e72ee68f6ba93
Gerrit-Change-Number: 55287
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 15:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment