Change in coreboot[master]: drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37053 )
Change subject: drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support
Drop stale comment.
Change-Id: Ie9f5271074ac4876f08fa8470dbc35daf5b694b2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/amd/agesa/def_callouts.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/37053/1
diff --git a/src/drivers/amd/agesa/def_callouts.c b/src/drivers/amd/agesa/def_callouts.c index 2e75220..ea8feae 100644 --- a/src/drivers/amd/agesa/def_callouts.c +++ b/src/drivers/amd/agesa/def_callouts.c @@ -187,7 +187,6 @@ #if HAS_AGESA_FCH_OEM_CALLOUT void agesa_fch_oem_config(uintptr_t Data, AMD_CONFIG_PARAMS *StdHeader) { - /* FIXME: CAR_GLOBAL needed here to pass sysinfo. */ struct sysinfo *cb_NA = NULL;
if (StdHeader->Func == AMD_INIT_RESET) {
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37053 )
Change subject: drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37053 )
Change subject: drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+2
I'll probably revisit those prototypes to remove cb_NA in near future.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37053 )
Change subject: drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
drivers/amd/agesa/def_callouts.c: Drop CAR_GLOBAL_MIGRATION support
Drop stale comment.
Change-Id: Ie9f5271074ac4876f08fa8470dbc35daf5b694b2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37053 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/amd/agesa/def_callouts.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/amd/agesa/def_callouts.c b/src/drivers/amd/agesa/def_callouts.c index 4b78d63..bce90d9 100644 --- a/src/drivers/amd/agesa/def_callouts.c +++ b/src/drivers/amd/agesa/def_callouts.c @@ -175,7 +175,6 @@ #if HAS_AGESA_FCH_OEM_CALLOUT void agesa_fch_oem_config(uintptr_t Data, AMD_CONFIG_PARAMS *StdHeader) { - /* FIXME: CAR_GLOBAL needed here to pass sysinfo. */ struct sysinfo *cb_NA = NULL;
if (StdHeader->Func == AMD_INIT_RESET) {
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)