Attention is currently required from: Jérémy Compostella.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80810?usp=email )
Change subject: arch/x86/car.ld: Move FSP RC heap region into car_region ......................................................................
arch/x86/car.ld: Move FSP RC heap region into car_region
This fixes linker warnings about the dot moving backwards.
Change-Id: I44b127f8cdf5aa00e9f85a26f5abc290d0dfc11b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/car.ld 1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/80810/1
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 8e1af15..dc46f47 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -8,7 +8,9 @@ . = CONFIG_DCACHE_RAM_BASE; .car.data . (NOLOAD) : { _car_region_start = . ; - . += CONFIG_FSP_M_RC_HEAP_SIZE; +#if CONFIG_FSP_M_RC_HEAP_SIZE > 0 + REGION(fspm_rc_heap, ., CONFIG_FSP_M_RC_HEAP_SIZE, 16) +#endif #if CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND) REGION(fspm_heap, ., CONFIG_FSP_TEMP_RAM_SIZE, 16) #endif @@ -109,11 +111,6 @@ _car_region_end = . + CONFIG_DCACHE_RAM_SIZE - (. - _car_region_start) - CONFIG_FSP_T_RESERVED_SIZE;
-. = _car_region_start; -.car.fspm_rc_heap . (NOLOAD) : { - . += CONFIG_FSP_M_RC_HEAP_SIZE; -} - . = _car_region_end; .car.mrc_var . (NOLOAD) : { . += CONFIG_DCACHE_RAM_MRC_VAR_SIZE;