Change in coreboot[master]: mb/google/brya/var/kano: Add gpio-keys ACPI node for PENH - coreboot-gerrit

10 Nov 2021


      Attention is currently required from: David Wu, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59035 )
Change subject: mb/google/brya/var/kano: Add gpio-keys ACPI node for PENH
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59035/comment/1e39a114_bfa7e8ad 
PS2, Line 7: register "pmc_gpe0_dw1" = "GPP_D"
I think it would be better to override this setting in kano's overridetree instead of the baseboard, so we don't accidentally break any wake pins other boards may have in GPP_E
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia36119678cfd5c65a62685d3312537d9aa21e83b
Gerrit-Change-Number: 59035
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 02:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment