Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50442 )
Change subject: drivers/i2c/hid: Enforce level triggered IRQ mode ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/50442/comment/f819a781_c47e1901 PS2, Line 79: dev->enabled = 0; I can update the IRQ mode to use LEVEL triggered with a warning. But if the HID device is not really following the specification, won't updating the IRQ mode mask the issue and lead to undefined behavior until someone notices the warning?
Also, there are two irq configs -- irq and irq_gpio. Probably need to check which is actually being used by the board first?
Yes I will update the code to handle this.
-
Karthik Ramasubramanian (Code Review)