Attention is currently required from: Paul Menzel, Shuo Liu, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87182?usp=email )
Change subject: cpu/x86: Conditionally invalidate caches based on self-snooping support
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87182/comment/2bf586bc_220f88e3?usp... :
PS3, Line 16: Rationale:
:
: -
I don't think the highlighted text brings anything.
https://review.coreboot.org/c/coreboot/+/87182/comment/f7b82557_ac51e72a?usp... :
PS3, Line 37: Able to reduce
: boot time by ~19-25ms.
On all three platforms?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87182?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If32439752d0ceaa03b1d81873ea0bc562092e9d5
Gerrit-Change-Number: 87182
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 19:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes