Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81889?usp=email )
Change subject: sb/intel/ibexpeak: Sever bd82x6x source dependency ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81889/comment/2cdfcffd_aaf9da2b : PS1, Line 13: TEST=Timeless binary did not change.
For which board? Please specify
This was done via abuild so all 3 boards with ibexpeak are covered: lenovo/t410, lenovo/x201 (two abuild configs), packardbell/ms2290.
File src/southbridge/intel/ibexpeak/chip.h:
https://review.coreboot.org/c/coreboot/+/81889/comment/747b5e0a_9ac8bd56 : PS1, Line 71: /* These USB3 fields, copied from bd82x6x, don't apply here, : * as Ibex Peak doesn't have USB3. */ : uint32_t xhci_switchable_ports; : uint32_t superspeed_capable_ports; : uint32_t xhci_overcurrent_mapping;
Do you mind dropping these in a follow-up? Thanks in advance
Will do. I left them behind for now so I can prove I didn't upset the compiled binary during the copy.