Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38633 )
Change subject: util/cbfstool: Fix typos ......................................................................
util/cbfstool: Fix typos
Found by: util/lint/checkpatch.pl --types TYPO_SPELLING --fix-inplace --strict --terse -f util/cbfstool/*.c
Change-Id: I13a27407bf2bad4b9fadcec8cdbd5889068f13cf Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/cbfs_image.c M util/cbfstool/elfheaders.c M util/cbfstool/fit.c M util/cbfstool/ifwitool.c M util/cbfstool/rmodule.c 6 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38633/1
diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index d6c10ad..830fe16 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -115,7 +115,7 @@ }
/* Now, regular headers - we only care about PT_LOAD headers, - * because thats what we're actually going to load + * because that's what we're actually going to load */
for (i = 0; i < headers; i++) { diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 452c9d9..9bf3688 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -576,7 +576,7 @@ continue;
/* At this point prev is an empty entry. Put the non-empty - * file in prev's location. Then add a new emptry entry. This + * file in prev's location. Then add a new empty entry. This * essentialy bubbles empty entries towards the end. */
prev_size = cbfs_file_entry_size(prev); diff --git a/util/cbfstool/elfheaders.c b/util/cbfstool/elfheaders.c index 676a635..53fe7a1 100644 --- a/util/cbfstool/elfheaders.c +++ b/util/cbfstool/elfheaders.c @@ -658,7 +658,7 @@ } }
-/* Arbitray maximum number of sections. */ +/* Arbitrary maximum number of sections. */ #define MAX_SECTIONS 16 struct elf_writer_section { Elf64_Shdr shdr; diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c index ee12c96..8ba50f7 100644 --- a/util/cbfstool/fit.c +++ b/util/cbfstool/fit.c @@ -172,7 +172,7 @@ * This one is critical, as mentioned in Chapter 1.2.1 "FIT Ordering Rules" * "Firmware Interface Table BIOS Specification". * - * We need to use a stable sorting algortihm, as the order of + * We need to use a stable sorting algorithm, as the order of * FIT_TYPE_BIOS_STARTUP matter for measurements. */ static void sort_fit_table(struct fit_table *fit) diff --git a/util/cbfstool/ifwitool.c b/util/cbfstool/ifwitool.c index 76b84e2..b25db4f 100644 --- a/util/cbfstool/ifwitool.c +++ b/util/cbfstool/ifwitool.c @@ -387,7 +387,7 @@
/* * Read header/entry members in little-endian format. - * Returns the offset upto which the read was performed. + * Returns the offset up to which the read was performed. */ static size_t read_member(void *src, size_t offset, size_t size_bytes, void *dst) @@ -415,7 +415,7 @@
/* * Convert to little endian format. - * Returns the offset upto which the fixup was performed. + * Returns the offset up to which the fixup was performed. */ static size_t fix_member(void *data, size_t offset, size_t size_bytes) { @@ -677,7 +677,7 @@
/* * Sub-partitions in IFWI image are not in the same order as - * in BPDT entries. BPDT entires are in header_order whereas + * in BPDT entries. BPDT entries are in header_order whereas * sub-partition offsets in the image are in pack_order. */ if ((e[i].offset + e[i].size) > max_offset) diff --git a/util/cbfstool/rmodule.c b/util/cbfstool/rmodule.c index 80e8911..1d087b1 100644 --- a/util/cbfstool/rmodule.c +++ b/util/cbfstool/rmodule.c @@ -223,7 +223,7 @@ }
if (nsegments != 1) { - ERROR("Unexepcted number of loadable segments: %d.\n", + ERROR("Unexpected number of loadable segments: %d.\n", nsegments); return -1; }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38633 )
Change subject: util/cbfstool: Fix typos ......................................................................
Patch Set 1: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38633 )
Change subject: util/cbfstool: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38633 )
Change subject: util/cbfstool: Fix typos ......................................................................
util/cbfstool: Fix typos
Found by: util/lint/checkpatch.pl --types TYPO_SPELLING --fix-inplace --strict --terse -f util/cbfstool/*.c
Change-Id: I13a27407bf2bad4b9fadcec8cdbd5889068f13cf Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38633 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/cbfs_image.c M util/cbfstool/elfheaders.c M util/cbfstool/fit.c M util/cbfstool/ifwitool.c M util/cbfstool/rmodule.c 6 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved
diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index d6c10ad..830fe16 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -115,7 +115,7 @@ }
/* Now, regular headers - we only care about PT_LOAD headers, - * because thats what we're actually going to load + * because that's what we're actually going to load */
for (i = 0; i < headers; i++) { diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 452c9d9..9bf3688 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -576,7 +576,7 @@ continue;
/* At this point prev is an empty entry. Put the non-empty - * file in prev's location. Then add a new emptry entry. This + * file in prev's location. Then add a new empty entry. This * essentialy bubbles empty entries towards the end. */
prev_size = cbfs_file_entry_size(prev); diff --git a/util/cbfstool/elfheaders.c b/util/cbfstool/elfheaders.c index 676a635..53fe7a1 100644 --- a/util/cbfstool/elfheaders.c +++ b/util/cbfstool/elfheaders.c @@ -658,7 +658,7 @@ } }
-/* Arbitray maximum number of sections. */ +/* Arbitrary maximum number of sections. */ #define MAX_SECTIONS 16 struct elf_writer_section { Elf64_Shdr shdr; diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c index ee12c96..8ba50f7 100644 --- a/util/cbfstool/fit.c +++ b/util/cbfstool/fit.c @@ -172,7 +172,7 @@ * This one is critical, as mentioned in Chapter 1.2.1 "FIT Ordering Rules" * "Firmware Interface Table BIOS Specification". * - * We need to use a stable sorting algortihm, as the order of + * We need to use a stable sorting algorithm, as the order of * FIT_TYPE_BIOS_STARTUP matter for measurements. */ static void sort_fit_table(struct fit_table *fit) diff --git a/util/cbfstool/ifwitool.c b/util/cbfstool/ifwitool.c index 76b84e2..b25db4f 100644 --- a/util/cbfstool/ifwitool.c +++ b/util/cbfstool/ifwitool.c @@ -387,7 +387,7 @@
/* * Read header/entry members in little-endian format. - * Returns the offset upto which the read was performed. + * Returns the offset up to which the read was performed. */ static size_t read_member(void *src, size_t offset, size_t size_bytes, void *dst) @@ -415,7 +415,7 @@
/* * Convert to little endian format. - * Returns the offset upto which the fixup was performed. + * Returns the offset up to which the fixup was performed. */ static size_t fix_member(void *data, size_t offset, size_t size_bytes) { @@ -677,7 +677,7 @@
/* * Sub-partitions in IFWI image are not in the same order as - * in BPDT entries. BPDT entires are in header_order whereas + * in BPDT entries. BPDT entries are in header_order whereas * sub-partition offsets in the image are in pack_order. */ if ((e[i].offset + e[i].size) > max_offset) diff --git a/util/cbfstool/rmodule.c b/util/cbfstool/rmodule.c index 80e8911..1d087b1 100644 --- a/util/cbfstool/rmodule.c +++ b/util/cbfstool/rmodule.c @@ -223,7 +223,7 @@ }
if (nsegments != 1) { - ERROR("Unexepcted number of loadable segments: %d.\n", + ERROR("Unexpected number of loadable segments: %d.\n", nsegments); return -1; }
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)