EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
mb/google/brya: Add flashmap descriptor
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia1ba8c997680c60ee1eabfae82459e127f664117 --- M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/chromeos.fmd 2 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/48062/1
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index db2252a..2c0e513 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -2,3 +2,4 @@ bool "Brya 0" select BOARD_GOOGLE_BASEBOARD_BRYA select BASEBOARD_BRYA_LAPTOP + select BOARD_ROMSIZE_KB_32768 diff --git a/src/mainboard/google/brya/chromeos.fmd b/src/mainboard/google/brya/chromeos.fmd new file mode 100644 index 0000000..64776fe --- /dev/null +++ b/src/mainboard/google/brya/chromeos.fmd @@ -0,0 +1,49 @@ +FLASH@0xfe000000 0x2000000 { + SI_ALL@0x0 0x500000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x4ff000 + } + SI_BIOS@0x500000 0x1b00000 { + # Place RW_LEGACY at the start of BIOS region such that the rest + # of BIOS regions start at 16MiB boundary. Since this is a 32MiB + # SPI flash only the top 16MiB actually gets memory mapped. + RW_LEGACY(CBFS)@0x0 0xb00000 + RW_SECTION_A@0xb00000 0x5e0000 { + VBLOCK_A@0x0 0x10000 + FW_MAIN_A(CBFS)@0x10000 0x32ffc0 + RW_FWID_A@0x33ffc0 0x40 + ME_RW_A(CBFS)@0x340000 0x2a0000 + } + RW_SECTION_B@0x10e0000 0x5e0000 { + VBLOCK_B@0x0 0x10000 + FW_MAIN_B(CBFS)@0x10000 0x32ffc0 + RW_FWID_B@0x33ffc0 0x40 + ME_RW_B(CBFS)@0x340000 0x2a0000 + } + RW_MISC@0x16c0000 0x40000 { + UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { + RECOVERY_MRC_CACHE@0x0 0x10000 + RW_MRC_CACHE@0x10000 0x20000 + } + RW_ELOG(PRESERVE)@0x30000 0x4000 + RW_SHARED@0x34000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD(PRESERVE)@0x38000 0x2000 + RW_NVRAM(PRESERVE)@0x3a000 0x6000 + } + # Make WP_RO region align with SPI vendor + # memory protected range specification. + WP_RO@0x1700000 0x400000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x3fc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0x3000 + COREBOOT(CBFS)@0x4000 0x3f8000 + } + } + } +}
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
Patch Set 1:
Just followed volteer, I think we can adjust this if needed? Not sure the ME region now.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
Patch Set 1:
oh, will add with mainboard configs
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
Set Ready For Review
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
Patch Set 1:
Oh, Tim already done, the left things can done with other CL. I think this is fine?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
Patch Set 2: Code-Review+2
Patch Set 1:
Oh, Tim already done, the left things can done with other CL. I think this is fine?
Looks good for now
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48062 )
Change subject: mb/google/brya: Add flashmap descriptor ......................................................................
mb/google/brya: Add flashmap descriptor
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia1ba8c997680c60ee1eabfae82459e127f664117 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48062 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/chromeos.fmd 2 files changed, 50 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index db2252a..2c0e513 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -2,3 +2,4 @@ bool "Brya 0" select BOARD_GOOGLE_BASEBOARD_BRYA select BASEBOARD_BRYA_LAPTOP + select BOARD_ROMSIZE_KB_32768 diff --git a/src/mainboard/google/brya/chromeos.fmd b/src/mainboard/google/brya/chromeos.fmd new file mode 100644 index 0000000..64776fe --- /dev/null +++ b/src/mainboard/google/brya/chromeos.fmd @@ -0,0 +1,49 @@ +FLASH@0xfe000000 0x2000000 { + SI_ALL@0x0 0x500000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x4ff000 + } + SI_BIOS@0x500000 0x1b00000 { + # Place RW_LEGACY at the start of BIOS region such that the rest + # of BIOS regions start at 16MiB boundary. Since this is a 32MiB + # SPI flash only the top 16MiB actually gets memory mapped. + RW_LEGACY(CBFS)@0x0 0xb00000 + RW_SECTION_A@0xb00000 0x5e0000 { + VBLOCK_A@0x0 0x10000 + FW_MAIN_A(CBFS)@0x10000 0x32ffc0 + RW_FWID_A@0x33ffc0 0x40 + ME_RW_A(CBFS)@0x340000 0x2a0000 + } + RW_SECTION_B@0x10e0000 0x5e0000 { + VBLOCK_B@0x0 0x10000 + FW_MAIN_B(CBFS)@0x10000 0x32ffc0 + RW_FWID_B@0x33ffc0 0x40 + ME_RW_B(CBFS)@0x340000 0x2a0000 + } + RW_MISC@0x16c0000 0x40000 { + UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { + RECOVERY_MRC_CACHE@0x0 0x10000 + RW_MRC_CACHE@0x10000 0x20000 + } + RW_ELOG(PRESERVE)@0x30000 0x4000 + RW_SHARED@0x34000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD(PRESERVE)@0x38000 0x2000 + RW_NVRAM(PRESERVE)@0x3a000 0x6000 + } + # Make WP_RO region align with SPI vendor + # memory protected range specification. + WP_RO@0x1700000 0x400000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x3fc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0x3000 + COREBOOT(CBFS)@0x4000 0x3f8000 + } + } + } +}
-
EricR Lai (Code Review) -
Tim Wawrzynczak (Code Review)