Attention is currently required from: Felix Held, Matt DeVillier, Paul Menzel.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80204?usp=email )
Change subject: mb/amd/onyx_poc: Add and use APCB configuration data
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80204/comment/6dcc2bd1_136613cb :
PS2, Line 9: This patch replaces [76445](https://review.coreboot.org/c/blobs/+/76445)
This could go to the end. Maybe also name it change-set …. […]
Done
https://review.coreboot.org/c/coreboot/+/80204/comment/ff3e3962_bf369b19 :
PS2, Line 10: It brings onyx_poc in-line with skyrim, guybrush and zork.
It means we're moving the APCB data to the mainboard dir, as was already done with the other listed […]
Done
Patchset:
PS6:
sorry for multiple patchsets, was experimenting a bit with clickable links 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80204?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c34528fa0fd15b847c22c995713078c60ac3873
Gerrit-Change-Number: 80204
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Jan 2024 17:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment