Attention is currently required from: Arthur Heymans, Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75031?usp=email )
Change subject: util/xcompile: Add target architecture to CPPFLAGS
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File src/arch/arm/armv7/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/75031/comment/7077f7c2_de15f094 :
PS12, Line 12: armv7_flags += -mfpu=none
nit: Maybe we should consider also moving these two into xcompile?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1
Gerrit-Change-Number: 75031
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 20 Mar 2024 22:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment