Attention is currently required from: Arthur Heymans, Julius Werner, Maximilian Brune, Nico Huber.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80776?usp=email )
Change subject: lib: Declare heap in assembly
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
tested on rex and looks good. lets land this cl.
PS2:
yes before this patch i saw this error:
[INFO ] MMAP window: SPI flash base=0x1000000, Host base=0xff000000, Size=0x1000000
[INFO ] CBFS: Found 'fallback/ramstage' @0x98b40 size 0x1eb44 in mcache @0x789fd10c
[DEBUG] Loading module at 0x78995000 with entry 0x78995000. filesize: 0x41340 memsize: 0x58af0
[DEBUG] Processing 4940 relocs. Offset value of 0x74995000
[DEBUG] Error: Can't add stage_cache 57a9e100 to imd
After applying this patch it is gone.
```
[DEBUG] Error: Can't add stage_cache 57a9e100 to imd
```
shouldn't this has to be treated as ERROR type instead debug ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67cb5ce886fda313e0720b0bc7c6e66e4aae45fa
Gerrit-Change-Number: 80776
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 28 Feb 2024 16:59:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment