Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 )
Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67342/comment/eb16c546_d9eca97d
PS5, Line 7: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
Please make it a statement [1]. Maybe:
Support SC16IS750 I2C to UART converter chip
[1]: https://cbea.ms/git-commit/
File src/drivers/smbus/sc16is750_init.c:
https://review.coreboot.org/c/coreboot/+/67342/comment/b1fd6736_76aeb275
PS5, Line 4:
Mention the datasheet name and revision somewhere?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145
Gerrit-Change-Number: 67342
Gerrit-PatchSet: 5
Gerrit-Owner: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 06 Sep 2022 16:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment